move request.user check to earlier in check_item_permissions
#76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cast` needed to make static type checkers happy fails if `django.contrib.auth` is installed but there is no user attached to a request. This can happen for a couple of reasons: - in tests (look at this repo's test suite for all the times I had to attach a fake user to the request) - in a single file Django application using with a library that requires `django.contrib.auth`, but in the demo you don't need or care about needing an actual user. Moving the check to before the cast allows the function to early if there is no user attached. We also make the assumption that if the item has *any* permissions defined and there is no request user, that the item should be hidden.
jefftriplett
approved these changes
Apr 25, 2024
Contributor
jefftriplett
left a comment
jefftriplett
left a comment
There was a problem hiding this comment.
One "future Josh will wonder why this exists" comment which is totally optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
castneeded to make static type checkers happy fails ifdjango.contrib.authis installed but there is no user attached to a request.This can happen for a couple of reasons:
django.contrib.auth, but in the demo you don't need or care about needing an actual user.Moving the check to before the cast allows the function to early if there is no user attached. We also make the assumption that if the item has any permissions defined and there is no request user, that the item should be hidden.