Skip to content

Commit

Permalink
PARQUET-711: Use metadata builders in parquet writer
Browse files Browse the repository at this point in the history
I wrote a sample file and the metadata seems to be correct.
@xhochy I fixed some missing metadata like `dictionary_page_offset`. You might want to check if this fixes the Drill problem.

Author: Deepak Majeti <deepak.majeti@hpe.com>

Closes apache#156 from majetideepak/PARQUET-711 and squashes the following commits:

25f5a7e [Deepak Majeti] fix schema and descr. Resolves PARQUET-705 and PARQUET-707
8b4784d [Deepak Majeti] Review comments to add methods back
fdbc761 [Deepak Majeti] fix clang error and comments
c6cb071 [Deepak Majeti] convert DCHECKS to Exceptions in metadata
ada3ac2 [Deepak Majeti] clang format
d9c9131 [Deepak Majeti] Use metadata builders in parquet writer

Change-Id: Iabe80b1cbe3fd8f1de6239187058b6402b160975
  • Loading branch information
Deepak Majeti authored and wesm committed Sep 9, 2016
1 parent deb99b9 commit c07ae9c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/tools/parquet/parquet-dump-schema.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ int main(int argc, char** argv) {
try {
std::unique_ptr<parquet::ParquetFileReader> reader =
parquet::ParquetFileReader::OpenFile(filename);
PrintSchema(reader->metadata()->schema_descriptor()->schema().get(), std::cout);
PrintSchema(reader->metadata()->schema()->schema_root().get(), std::cout);
} catch (const std::exception& e) {
std::cerr << "Parquet error: " << e.what() << std::endl;
return -1;
Expand Down

0 comments on commit c07ae9c

Please sign in to comment.