04 - Array Cardio Day 1, 7. sort Exercise | make it so it sorts on last name #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In your video you still sort on the first name of the array but you called it `aLast` and `bLast` but they where in the first position of the array like this: `const [aLast, aFirst]` when changed to `const [aFirst, aLast]` it will filter on the second part of the array. There for it will sort on the last name. To bad there is no way to pull request your video.
mvaneijgen
changed the title
Owner
|
Yes - good catch. I mixed these up in the video. THanks |
YuriBrunetto
added a commit
to YuriBrunetto/JavaScript30
that referenced
this pull request
Feb 16, 2017
deeheber
added a commit
to deeheber/JavaScript30
that referenced
this pull request
Apr 19, 2017
kdipaolo
added a commit
to kdipaolo/JavaScript30
that referenced
this pull request
Apr 24, 2017
ShimmiChristo
added a commit
to ShimmiChristo/JavaScript30
that referenced
this pull request
Jan 3, 2018
EmmDguez
pushed a commit
to EmmDguez/JavaScript30
that referenced
this pull request
Jun 10, 2018
04 - Array Cardio Day 1, 7. sort Exercise | make it so it sorts on last name
smchenrybc
added a commit
to smchenrybc/JavaScript30
that referenced
this pull request
Aug 2, 2018
Watson6982
added a commit
to lgss/JavaScript30
that referenced
this pull request
Sep 28, 2018
tiago-m-dias
added a commit
to tiago-m-dias/JavaScript30
that referenced
this pull request
May 7, 2019
Challenge wesbos#28
bSkinny2
pushed a commit
to bSkinny2/JavaScript30
that referenced
this pull request
Mar 20, 2024
Update installation instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your video you still sort on the first name of the array but you called it
aLastandbLastbut they where in the first position of the array like this:const [aLast, aFirst]when changed toconst [aFirst, aLast]it will filter on the second part of the array. There for it will sort on the last name.To bad there is no way to pull request your video.