Skip to content

Commit

Permalink
update python3 version for testing to 3.6 (apache#5562)
Browse files Browse the repository at this point in the history
* update python version for testing to 3.6

* CONTRIBUTING.md states pull requests should work on py27, py36+

* CONTRIBUTING.md states pull requests should work on py27 and py36
  • Loading branch information
octaviancorlade authored and john-bodley committed Aug 7, 2018
1 parent 9f734a3 commit 14e5ee6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ meets these guidelines:
3. If the pull request adds functionality, the docs should be updated
as part of the same PR. Doc string are often sufficient, make
sure to follow the sphinx compatible standards.
4. The pull request should work for Python 2.7, and ideally Python 3.4+.
4. The pull request should work for Python 2.7 and Python 3.6.
``from __future__ import`` will be required in every `.py` file soon.
5. If the pull request adds a Python dependency include it in `setup.py`
denoting any specific restrictions and in `requirements.txt` pinned to a
Expand Down Expand Up @@ -291,7 +291,7 @@ All python tests can be run with any of the tox [environments](http://tox.readth
i.e.,

tox -e py27
tox -e py34
tox -e py36

Alternatively, you can run all tests in a single file via,

Expand Down
2 changes: 1 addition & 1 deletion docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Installation & Configuration
Getting Started
---------------

Superset is tested against Python ``2.7`` and Python ``3.4``.
Superset is tested against Python ``2.7`` and Python ``3.6``.
Airbnb currently uses 2.7.* in production. We do not plan on supporting
Python ``2.6``.

Expand Down
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ setenv =
SUPERSET_CONFIG = tests.superset_test_config
SUPERSET_HOME = {envtmpdir}
py27-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset?charset=utf8
py{34,36}-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset
py{27,34,36}-postgres: SUPERSET__SQLALCHEMY_DATABASE_URI = postgresql+psycopg2://postgresuser:pguserpassword@localhost/superset
py{27,34,36}-sqlite: SUPERSET__SQLALCHEMY_DATABASE_URI = sqlite:////{envtmpdir}/superset.db
py36-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset
py{27,36}-postgres: SUPERSET__SQLALCHEMY_DATABASE_URI = postgresql+psycopg2://postgresuser:pguserpassword@localhost/superset
py{27,36}-sqlite: SUPERSET__SQLALCHEMY_DATABASE_URI = sqlite:////{envtmpdir}/superset.db
whitelist_externals =
npm

Expand Down

0 comments on commit 14e5ee6

Please sign in to comment.