Create Untrivial Logic in Finally Block Rule #3461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Jun 16, 2025
flake.nix
Outdated
.gitignore
Outdated
| @@ -1,4 +1,7 @@ | |||
| #### joe made this: http://goel.io/joe | |||
| #### NIX #### | |||
| flake.lock | |||
There was a problem hiding this comment.
Please, add a test case with a custom setting.
There was a problem hiding this comment.
Suggested change
| Forbids "fat" finally block. | |
| Forbids complex finally block. |
There was a problem hiding this comment.
Suggested change
| class UntrivialLogicInFinallyViolation(ASTViolation): | |
| class ComplexFinallyViolation(ASTViolation): |
There was a problem hiding this comment.
Suggested change
| error_template = 'Found untrivial logic in `finally` block: {0}' | |
| error_template = 'Found complex `finally` block: {0}' |
sobolevn
reviewed
Jun 16, 2025
| Default: | ||
| :int:`wemake_python_styleguide.options.defaults.MAX_LINES_IN_FINALLY. | ||
| ..versionadded:: 1.1.0 |
There was a problem hiding this comment.
Suggested change
| ..versionadded:: 1.1.0 | |
| ..versionadded:: 1.2.0 |
|
For now some test checks doesn't work correctly. |
i cant install dependencies error log. I use poetry install |
|
Please, attach error log as a text, not a file. I don't want to download any files. |
sobolevn
reviewed
Jun 16, 2025
Co-authored-by: sobolevn <mail@sobolevn.me>
|
|
@alexeev-prog you are using 3.14 which is not supported, please use 3.13 :) |
|
My local testing logs: https://pastebin.com/qJp9nkLp |
|
Please help, i am not understand test errors... |
|
Please, fix WPS errors first. Tests are not even executed :) |
sobolevn
reviewed
Jun 27, 2025
tests/fixtures/noqa/noqa.py
Outdated
| my_print(first_argpm, second_argpm) | ||
|
|
||
|
|
||
| Я |
There was a problem hiding this comment.
Why is it named complex_continue? When it checks complex try finally blocks?
There was a problem hiding this comment.
So sorry! I renamed it.
|
In my local environment, i got tests error: Whats is solution of fix it? |
sobolevn
reviewed
Jun 27, 2025
|
|
||
| # Wrong examples: | ||
|
|
||
| untrivial_logic_example1 = """ |
There was a problem hiding this comment.
It is the same as trivial_logic_custom_example1
|
|
||
| # Correct examples: | ||
|
|
||
| trivial_logic_example1 = """ |
There was a problem hiding this comment.
Please, add two test cases with try/finally without except: both correct and incorrect ones.
There was a problem hiding this comment.
I add this, by i get Total coverage: 99.91% in local tests.
sobolevn
reviewed
Jun 27, 2025
|
|
||
| total_lines = 0 | ||
|
|
||
| for stmt in node.finalbody: |
There was a problem hiding this comment.
You don't need any of this. Here's the code you need:
if not node.finalbody:
return
first_line = node.finalbody[0].lineno
last_line = node.finalbody[-1].lineno
total_lines = last_line - first_line
if total_lines > self.options.max_lines_in_finally:
self.add_violation(
complexity.ComplexFinallyViolation(
node,
text=str(total_lines),
baseline=self.options.max_lines_in_finally,
),
)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3461 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 362 364 +2
Lines 11987 12040 +53
Branches 821 823 +2
=========================================
+ Hits 11987 12040 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Its ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Untrivial Logic in Finally Block Rule
Checklist
CHANGELOG.mdRelated issues
Closes #3458