Update to pytest >= 7.0.0 and use importlib_metadata to get versions #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml: Update the pytest dependency to >= 7.0.0, which obsoletes the use of pytest-pythonpath. setup.cfg: Change the python_paths pytest configuration option to pythonpath, as that is what is used with pytest >= 7.0.0."
poetry.lock: Update poetry lock file after updating pytest version requirement and removing pytest-pythonpath.
pyproject.toml: Using importlib_metadata it is possible to derive versions of packages. To make use of it with python < 3.10 the package importlib_metadata has to be added (conditionally).
poetry.lock: Update poetry lock after adding importlib_metadata conditionally.
dvzrv
force-pushed
the
fix_pytest_and_importlib
branch
from
35202a7 to
91feca4
Compare
dvzrv
commented
Sep 26, 2022
|
Ouf, that CI is very flaky! :S |
dvzrv
force-pushed
the
fix_pytest_and_importlib
branch
2 times, most recently
from
4f2caf0 to
53e40dd
Compare
setup.cfg: Disable the warning for unused ignores in mypy as there seems to be an issue between versions of mypy about what is considered an "unused ignore".
coverage_conditional_plugin/__init__.py: Use importlib_metadata to derive package versions, instead of relying on pkg_resources (which implicitly dragged in setuptools).
dvzrv
force-pushed
the
fix_pytest_and_importlib
branch
from
53e40dd to
078baf9
Compare
setup.cfg: Disable WPS440 and WPS433 for plugin as they are requirements for the conditional import of importlib_metadata.
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 1 1
Lines 11 11
=======================================
Hits 10 10
Misses 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
archlinux-github
pushed a commit
to archlinux/repod
that referenced
this pull request
Sep 27, 2022
pyproject.toml: Update dependencies to their latest versions. Remove setuptools, as coverage-conditional-plugin no longer implicitly requires it (wemake-services/coverage-conditional-plugin#177).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
Fixes #154