fix(miniscore): _.defaults behavior for null (#41) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the _.defaults behavior to match that of underscore and lodash to no longer treat `null` and `undefined` the same and only consider `undefined` for override.
|
Hey @passy do you have tests planned for this? We ran into this issue recently and are curious about when this might be merged. Thanks! |
|
@nico-adstage No, this is very far down on my todo list at the moment. Best chance of getting this merged is someone stepping in for the tests. I'm happy to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the _.defaults behavior to match that of underscore and lodash to
no longer treat
nullandundefinedthe same and only considerundefinedfor override.Fix #41