reject a faulty delivery logic #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines Of Code
|
Go API Changes# summary Inferred base version: v5.1.2 Suggested version: v5.1.3 |
mariaefi29
commented
Jun 22, 2023
| eventuallyUnacked(t, queue, 0) | ||
| eventuallyRejected(t, queue, 6) | ||
|
|
||
| require.Len(t, consumer.Deliveries(), 0) |
There was a problem hiding this comment.
I am not sure if it's correct. I want to figure out why we have no deliveries. They should be rejected.
There was a problem hiding this comment.
Yes, I double-checked. This is an expected behaviour, we don't push those deliveries into the delivery channel.
Unit Test Coveragetotal: (statements) 71.8% Coverage of changed lines
Coverage diff with base branch
|
Benchmark ResultBenchmark diff with base branchBenchmark result |
wellle
reviewed
Jun 23, 2023
queue.go
Outdated
| } | ||
|
|
||
| rejectErr := rd.Reject() | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| if rejectErr != nil { |
?
There was a problem hiding this comment.
Oh, thank you! It was a bug!
Co-authored-by: Christian Wellenbrock <christian.wellenbrock@gmail.com>
wellle
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages with broken headers (for example, without a separator) has never been rejected and stayed forever in unack.
This PR fixes the bug. If there is an error creating a delivery, we will reject it.