Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ack failure for payload with header #137

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Fix ack failure for payload with header #137

merged 3 commits into from
Feb 8, 2023

Conversation

vearutop
Copy link
Contributor

@vearutop vearutop commented Feb 8, 2023

Fixes #138.

retract v5.1.0 considered for go.mod, but it would fail build for go1.15 and below.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 29 2931 (+1) 2149 (+1) 280 502 392 76.5K (+44B)
Go (test) 7 1505 (+6) 1209 (+5) 46 250 (+1) 84 42.8K (+586B)

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Benchmark Result

Benchmark diff with base branch
name     old time/op    new time/op    delta
Queue-2     234µs ±11%     231µs ± 8%   ~     (p=0.818 n=6+6)

name     old alloc/op   new alloc/op   delta
Queue-2    35.6kB ± 8%    35.7kB ±11%   ~     (p=0.818 n=6+6)

name     old allocs/op  new allocs/op  delta
Queue-2      87.5 ± 1%      87.7 ± 1%   ~     (p=1.000 n=6+6)
Benchmark result
name     time/op
Queue-2   231µs ± 8%

name     alloc/op
Queue-2  35.7kB ±11%

name     allocs/op
Queue-2    87.7 ± 1%

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Go API Changes

# summary
Inferred base version: v5.1.0
Suggested version: v5.1.1

@vearutop
Copy link
Contributor Author

vearutop commented Feb 8, 2023

Issue reproduced in test run: https://github.com/adjust/rmq/actions/runs/4126465190/jobs/7128426003.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Unit Test Coverage

total: (statements) 71.1%
changed lines: (statements) 83.3%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines
File Function Coverage
Total 83.3%
delivery.go 83.3%
delivery.go:39 newDelivery 100.0%
delivery.go:67 String 100.0%
delivery.go:71 Payload 100.0%
Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 70.9% 71.1% (+0.2%)
github.com/adjust/rmq/v5/delivery.go String 0.0% 100.0% (+100.0%)

@vearutop vearutop marked this pull request as ready for review February 8, 2023 17:37
@vearutop vearutop requested a review from wellle February 8, 2023 17:37
@vearutop vearutop merged commit 028d635 into master Feb 8, 2023
@vearutop vearutop deleted the fix-ack branch February 8, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delivery Ack/Reject fails when header is used
2 participants