Migrate to GitHub Actions #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines Of Code
|
Unit Test Coveragetotal: (statements) 69.3% Coverage of changed linesNo changes in testable statements. Coverage diff with base branchMissing base coverage file. |
Go API Changes# summary Inferred base version: v5.0.1 Suggested version: v5.1.0 |
Benchmark ResultBenchmark diff with base branchBenchmark result |
vearutop
force-pushed
the
github-actions
branch
2 times, most recently
from
59cb6a0 to
1d89bd1
Compare
vearutop
force-pushed
the
github-actions
branch
from
1d89bd1 to
2aa8a72
Compare
vearutop
force-pushed
the
github-actions
branch
from
2aa8a72 to
de42435
Compare
mariaefi29
approved these changes
Jan 24, 2023
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func testRedis(t testing.TB) (addr string, closer func()) { |
There was a problem hiding this comment.
What do you think if we put that func at the bottom of the test file?
There was a problem hiding this comment.
What's the rationale for such layout?
There was a problem hiding this comment.
I'll merge this PR and let's change this later if there are benefits.
There was a problem hiding this comment.
What's the rationale for such layout?
Unexported helpers functions are usually put at the end of file, since they are just helpers and not the main purpose of the file.
There is a layout approach I really like, I think I will share with the team later in Q1 to discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI seem to be no longer working for free for public repositories, so migrating to GitHub Actions can improve CI.
This PR
github.com/alicebob/miniredisto reduce test dependency on actual Redis (envREDIS_ADDRstill allows actual Redis),go.modwithgo1.17to optimize transitive dependencies handling.