Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue.Drain and redisClient.RPop method #124

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Add queue.Drain and redisClient.RPop method #124

merged 2 commits into from
Sep 1, 2022

Conversation

psampaz
Copy link
Contributor

@psampaz psampaz commented Aug 31, 2022

This PR add a queue.Drain removes and returns 'count' elements from the queue and the RPop method to redisClient

Blocked by #122

@psampaz psampaz force-pushed the drain branch 2 times, most recently from 4c9e52c to 2e5c35a Compare August 31, 2022 07:42
@psampaz psampaz marked this pull request as ready for review August 31, 2022 07:44
test_redis_client.go Outdated Show resolved Hide resolved
@psampaz psampaz requested a review from wellle August 31, 2022 08:21
Copy link
Owner

@wellle wellle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. One suggestion.

queue.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants