add some minimal checks for external urls in user app dialog

wellenvogel · Dec 27, 2024 · 362f9e3 · 362f9e3
1 parent 5ae38f6
commit 362f9e3
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/viewer/components/UserAppDialog.jsx b/viewer/components/UserAppDialog.jsx
@@ -219,6 +219,15 @@ const SelectExistingDialog=({existingAddons,resolveFunction})=>{
     </DialogFrame>
 }
 
+const checkUrl=(val,isInternal)=>{
+    if (! val) return "must not be empty";
+    if (isInternal){
+        if (val.match(/^http/i)) return "internal urls must not start with http";
+        return
+    }
+    if (!val.match(/^https*:\/\//i)) return "external urls must start with http[s]://";
+}
+
 const UserAppDialog = (props) => {
     const [currentAddon, setCurrentAddon] = useState({...props.addon, ...props.fixed});
     const dialogContext = useDialogContext();
@@ -286,6 +295,7 @@ const UserAppDialog = (props) => {
                             minSize={50}
                             maxSize={100}
                             mandatory={(v) => !v}
+                            checkFunction={(v)=>checkUrl(v,false) === undefined}
                             onChange={(val) => setCurrentAddon({...currentAddon, url: val})}/>
                         :
                         <InputReadOnly
@@ -425,7 +435,9 @@ const UserAppDialog = (props) => {
                         });
 
                     },
-                    {disabled: !currentAddon.icon || !currentAddon.url || !canEdit,close:false})
+                    {
+                        disabled: !currentAddon.icon || !currentAddon.url || !canEdit || checkUrl(currentAddon.url,internal) !== undefined,
+                        close:false})
             ]}/>
         </DialogFrame>
     );