Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for using named imports with trackExtraHooks #245

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented May 16, 2022

No description provided.

@CJamesKeller
Copy link

As a user, I agree that this would be a helpful addition.

@vzaidman
Copy link
Collaborator

vzaidman commented Jun 2, 2022

@xepozz isn't useSelector a named import? What is this example adding to the readme?

@xepozz
Copy link
Contributor Author

xepozz commented Jun 2, 2022

There is some misleading because a lot of people may not know about redux and don't use it in their project.
In general it may be confusing to see [someObject, 'familiar-method'] structure for new users, so I think my example is more informative then existed.
And one more point that it's a bit compact form that the existing one. 2 line vs 1.

In my project I use my variant and it seems good to me :)

@vzaidman vzaidman merged commit 0f364e8 into welldone-software:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants