Fix issues with references to spans #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivyleavedtoadflax
force-pushed
the
feature/ivyleavedtoadflax/prodigy_to_tsv
branch
from
6d6b74c to
096d9c5
Compare
ivyleavedtoadflax
force-pushed
the
feature/ivyleavedtoadflax/prodigy_to_tsv
branch
from
096d9c5 to
f51e8c6
Compare
Helps with debugging
ivyleavedtoadflax
force-pushed
the
feature/ivyleavedtoadflax/prodigy_to_tsv
branch
from
f51e8c6 to
99398ca
Compare
ivyleavedtoadflax
force-pushed
the
feature/ivyleavedtoadflax/prodigy_to_tsv
branch
from
c942446 to
42f270c
Compare
ivyleavedtoadflax
changed the title
ivyleavedtoadflax
changed the title
ivyleavedtoadflax
changed the title
lizgzil
reviewed
Feb 27, 2020
|
|
||
| spans = [] | ||
| spans.append(self.create_span(tokens, span["token_start"], start_label)) | ||
| spans.append(self.create_span(tokens, span["token_end"], end_label)) |
Contributor
There was a problem hiding this comment.
ah so was this line the cause of the bug in the case where span_size = 0 then?
Contributor
Author
There was a problem hiding this comment.
yep precisely! It was a case that had never come up before because references were always longer than one token.
lizgzil
approved these changes
Feb 27, 2020
Contributor
lizgzil
left a comment
lizgzil
left a comment
There was a problem hiding this comment.
LGTM 👍 make test was successful.
ivyleavedtoadflax
deleted the
feature/ivyleavedtoadflax/prodigy_to_tsv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a long PR, but it is mostly test data that has been added to
tests/prodigy/test_datato provide more realistic examples when testing conversion of reference annotations to token annotations. This PR:prodigy_to_tsvandrefs_to_token_annotationscommandssplit_long_spanmethod in theTokenTaggerclass which was causing some token level spans to be repeated when the reference span was of length = 1.