Skip to content

config_files: Do not remove chcon in runtime cleanup #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

elkoniu
Copy link
Contributor

@elkoniu elkoniu commented Jul 2, 2025

chcon is being used by the bootc and recently added to bootc.spec file as an explicite requirement: bootc-dev/bootc#1391 When it is not presented in the system the result is failure of the bootc install to-filesystem command used by Anaconda installer.

chcon is being used by the bootc and recently added to bootc.spec
file as an explicite requirement: bootc-dev/bootc#1391
When it is not presented in the system the result is failure of the
`bootc install to-filesystem` command used by Anaconda installer.
@elkoniu
Copy link
Contributor Author

elkoniu commented Jul 2, 2025

Related bootc + anaconda discussion: bootc-dev/bootc#1383

Copy link
Contributor

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jkonecny12
Copy link
Contributor

offtopic: I just wonder, I see /usr/bin/[ on the same line and it doesn't look as a smart idea to remove this to me. @bcl do you know why it's removed?

@elkoniu
Copy link
Contributor Author

elkoniu commented Jul 2, 2025

offtopic: I just wonder, I see /usr/bin/[ on the same line and it doesn't look as a smart idea to remove this to me. @bcl do you know why it's removed?

To be honest I am wondering how everything is able to work with /usr/bin/[ removed :)

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bcl
Copy link
Contributor

bcl commented Jul 2, 2025

To be honest I am wondering how everything is able to work with /usr/bin/[ removed :)

I expect that the shell handles it, the reasons for its removal are lost in the mists of time (I went back as far as commit bd476e1). I expect it was carried over from the old way of building things which used to use a pile of bash scripts in the anaconda repo.

We could stop removing it, but not without doing a bunch of tests first to make sure THAT doesn't break :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16025506060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.417%

Totals Coverage Status
Change from base Build 15914943807: 0.0%
Covered Lines: 1634
Relevant Lines: 3562

💛 - Coveralls

@bcl bcl merged commit 9e692eb into weldr:master Jul 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants