Re-export of TransactionManagerStatus #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this PR 👍 I potentially plan to relicense diesel-async in the future. (See #39) Because of that I need an explicitly written consent that you transfer the ownership of this change to me. Please add that to the commit message. |
weiznich
approved these changes
Nov 25, 2022
|
I agree to transfer the ownership of this change to @weiznich. Does that work? |
|
Yes that should be fine 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is intended, but
TransactionManagerStatusis effectively hidden from public access; however, this enum is required if you want to implement the traitTransactionManager, as the trait functionTransactionManager::transaction_manager_status_mutreturns aTransactionManagerStatusdirectly. As far as I can tell, it is accessible in diesel, even if gated behind a feature.