Skip to content

Conversation

@fluxxu
Copy link
Contributor

@fluxxu fluxxu commented Oct 7, 2022

If I understand it correctly, diesel_async::pooled_connection::deadpool::BuildError is the error returned when
deadpool::managed::PoolBuilder::build failed.
According to the docs, the error should be BuildError<M::Error> where M is AsyncDieselConnectionManager, so the error should be
deadpool::managed::BuildError<<AsyncDieselConnectionManager as deadpool::managed::Manager>::Error> which is

deadpool::managed::BuildError<diesel_async::pooled_connection::PoolError>,

but in the current code, it is an alias of

deadpool::managed::BuildError<deadpool::managed::PoolError<diesel_async::pooled_connection::PoolError>>

@weiznich weiznich closed this Oct 19, 2022
@weiznich
Copy link
Owner

Thanks for opening this PR. I potentially plan to relicense diesel-async in the future. Because of that I need an explicitly written consent that you transfer the ownership of this change to me. Please add that to the commit message.

(Hit the wrong button…)

@weiznich weiznich reopened this Oct 19, 2022
@fluxxu
Copy link
Contributor Author

fluxxu commented Oct 19, 2022

I consent that I transfer the ownership of this change to you.

@weiznich weiznich merged commit 6358fbe into weiznich:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants