Use render function instead of template for compatibility with runtime-only build of Vue. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2016 13:19
|
Thanks for your PR. |
|
Oh, I just realized that Vue 1.x doesn't support render function. |
weizhenye
added a commit
that referenced
this pull request
Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you run vue-highcharts in the runtime-only build of Vue (which seems to be the default, at least in a vue-cli project) it raises an error saying that the
templateoption is unsupported if you're using a build without the template compiler included.Since the template just created a container
<div>, I figured it would be easy enough to just swap it with a trivial render function. I've tried installing this build in my project, and it seems to work -- the tests also pass.