[pull] master from postalsys:master#183
Merged
pull[bot] merged 7 commits intoweiyilai:masterfrom Feb 26, 2026
Merged
Conversation
…lback (#580) Microsoft Graph API returns string error codes (e.g. "TooManyPendingRequests") in JSON error responses, unlike Google APIs which return numeric codes. Passing these strings to Boom.boomify() as statusCode causes an AssertError crash since Boom requires a numeric value >= 400. Extract resolveOAuthErrorStatus() helper into lib/tools.js to check if response.error.code is a valid numeric HTTP status code before using it, falling back to the HTTP status already captured on err.statusCode or err.oauthRequest.status.
Ensure fallback values (err.statusCode, err.oauthRequest.status) are validated as numeric >= 400 before passing to Boom.boomify(), preventing AssertError crashes from non-numeric or low status codes. Also fix test timeout by adding process.exit() workaround for Redis connection cleanup.
Add redirectToSlash and index:false to the static file directory handler to prevent Inert from attempting to read the directory path as a file, which causes an uncaught EISDIR exception in pkg snapshot environments.
redirectToSlash has no effect because the server uses stripTrailingSlash. The index:false option alone is sufficient to prevent the EISDIR crash.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )