Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguishing between JUnit final results and XUnit2 interim (rerun & flaky) results #144

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EnricoMi
Copy link
Collaborator

Improves class hierarchy and naming of results returned by JUnitXml.TestCase.result, in contrast to rerun results defined in xunit2.

Note: This is a breaking change. Before, TestCase.result silently ignored values that were not of type Result. This setter method now raises a ValueError if values are not of type FinalResult.

@EnricoMi EnricoMi force-pushed the rework-xunit2-rerun-types branch from 3d9d48e to 13f1182 Compare December 20, 2024 21:15
@EnricoMi EnricoMi requested a review from weiwei January 12, 2025 20:51
@EnricoMi EnricoMi marked this pull request as ready for review January 12, 2025 20:51
@EnricoMi EnricoMi force-pushed the rework-xunit2-rerun-types branch from 4c0e7c3 to 97c4be6 Compare January 13, 2025 13:17
@EnricoMi EnricoMi changed the title Distinguishing between JUnit final results and XUnit2 intermediate (rerun) results Distinguishing between JUnit final results and XUnit2 interim (rerun & flaky) results Jan 13, 2025
@EnricoMi EnricoMi force-pushed the rework-xunit2-rerun-types branch from 97c4be6 to 2d6dd39 Compare January 13, 2025 13:20
@EnricoMi EnricoMi force-pushed the rework-xunit2-rerun-types branch from 2d6dd39 to 19ba91e Compare January 13, 2025 14:19
@EnricoMi EnricoMi force-pushed the rework-xunit2-rerun-types branch from 19ba91e to ce2f1df Compare January 13, 2025 14:23
EnricoMi and others added 2 commits January 13, 2025 16:25
Co-authored-by: Jan Wille <mail@janwille.de>
Copy link

Test Results

  4 files    4 suites   0s ⏱️
 95 tests  95 ✅ 0 💤 0 ❌
380 runs  374 ✅ 6 💤 0 ❌

Results for commit 47fd7ca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant