Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/imports #55

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Chore/imports #55

merged 4 commits into from
Aug 17, 2021

Conversation

weiseng18
Copy link
Owner

@weiseng18 weiseng18 commented Aug 17, 2021

Problem

Want to enable backend absolute imports (for Typescript)

Solution

  • /app/* excluding /app/tests already supported absolute imports, so the imports were simply updated
  • /app/tests required extra work to support absolute imports, when running with mocha. ts-node does not support absolute paths, and in that page, the proposed solution was to use tsconfig-paths. The solution was used and it works.

Checklist

  • If the branch was not created off latest develop, merge locally
  • Using latest develop and master, do git diff --stat master while in develop branch. Ensure that the diff is not too large
  • If this is a feature, has appropriate documentation been added?

Notes

@vercel
Copy link

vercel bot commented Aug 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/weiseng18/math/8pVenHsKGWUdNMxDgchSkMAjTNgC
✅ Preview: https://math-git-chore-imports-weiseng18.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant