Add the ability to set the default font and change it in ThemeSettings

[Xujiayao]

I couldn't find a method in Darklaf to set the default font (the default font of Windows Darklaf is not designed for Chinese), so I used the following code and it works:

setDefaultFont(new FontUIResource(new Font("Microsoft YaHei", Font.PLAIN, 12)));

public static void setDefaultFont(FontUIResource defaultFont) {
	Enumeration<Object> keys = UIManager.getDefaults().keys();
	while (keys.hasMoreElements()) {
		Object key = keys.nextElement();
		Object value = UIManager.get(key);
		if (value instanceof FontUIResource)
			UIManager.put(key, defaultFont);
	}
}

However, after using the above code, the Font Size Settings of ThemeSettings no longer works (tried Apply and OK).

Another problem is that when I use the Locale.setDefault() method to set the Locale to a different language (e.g. English, Japanese), the ThemeSettings panel is still the default language used by the system (Chinese).

Maybe you can write a method that sets the default font and add it to ThemeSettings :)

After using the code	Normal situation

[weisJ]

This sounds like a reasonable feature :)

[weisJ]

Another problem is that when I use the Locale.setDefault() method to set the Locale to a different language (e.g. English, Japanese), the ThemeSettings panel is still the default language used by the system (Chinese).

There is no way to detect a changed locale automatically. You'll have to invalidate the ui manually. You can call LafManager.updateLaf() to do this.

[Xujiayao]

OK, I'll try it later.

[Xujiayao]

Another problem is that when I use the Locale.setDefault() method to set the Locale to a different language (e.g. English, Japanese), the ThemeSettings panel is still the default language used by the system (Chinese).

There is no way to detect a changed locale automatically. You'll have to invalidate the ui manually. You can call LafManager.updateLaf() to do this.

I remember when I posted this issue, it couldn't set the locale to a different language, but I don't seem to need to use LafManager.updateLaf() to set the locale to a different language now. It may have been fixed.

public static void main(String[] args) {
	SwingUtilities.invokeLater(() -> {
		LafManager.install(new DarculaTheme());
		Locale.setDefault(Locale.JAPANESE);

		JFrame frame = new JFrame("Darklaf - A themeable LaF for Swing");
		frame.setSize(600, 400);

		JButton button = new JButton("Click here!");

		JPanel content = new JPanel();
		content.add(button);

		frame.setLocationRelativeTo(null);
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		frame.setContentPane(content);
		frame.setVisible(true);

		button.addActionListener(e -> {
			ThemeSettings.showSettingsDialog(null);
		});
	});
}

[weisJ]

The issue should arise if you change the locale after the settings have already been opened once.

[Xujiayao]

Button click order: 1 -> 2 -> 3 -> 1 & 2 -> 3 -> 1

It seems that LafManager.updateLaf() doesn't work, and the same problem occurs whether ThemeSettings is opened once or not.

LafManager.install(new DarculaTheme());

// The same problem occurs regardless of whether this line appears or not
Locale.setDefault(Locale.ENGLISH);

...

button1.addActionListener(e -> {
	ThemeSettings.showSettingsDialog(null);
});

button2.addActionListener(e -> {
	Locale.setDefault(Locale.JAPANESE);
});

button3.addActionListener(e -> {
	LafManager.updateLaf();
});

[weisJ]

Ah the issue is that the laf has to actually be updated for the text to change. You can force this to happen by calling:

LafManager.installTheme(LafManager.getInstalledTheme().copy());

Currently this will print a warning message. Feel free to ignore it for now. I'll provide a better method to accomplish this without the message appearing.

[weisJ]

With the latest snapshot you are able to provide a prototype font:

LafManager.registerDefaultsAdjustmentTask((theme, props) -> {
    props.put("theme.fontPrototype", new Font("Microsoft YaHei", Font.PLAIN, 12));
});
Note that the font size is irrelevant and won't affect the size of other fonts. For this the font size in the theme settings is still the relevant authority. 

I know this isn't exactly what you had in mind, but until I can provide a nice looking way to select the font I think this will at least solve your problem at hand.

[Xujiayao]

Thanks! I'll test these new features tomorrow.

[Xujiayao]

Thank you! I just tested and both work.

I found a new problem while testing:

The font size of the title bar is reduced. However, if I enter the ThemeSettings Dialog to adjust the font to another size, click Apply, and then adjust it back to 100%, click Apply again, the font size will return to normal.

Before	After

[weisJ]

The fact that the font got bigger after changign the size is the actuall issue here. It actually should always be as in the "Before" iamge (if default font size is selected). Fixed in 3639369

[Xujiayao]

I just tried it and now the default size is the same as the "After" of the previous comment, which is the correct default size.

However, the following code to set the font does not work for the title bar:

After repeating the same operation as the previous comment, the font becomes the correct Microsoft YaHei.

LafManager.registerDefaultsAdjustmentTask((theme, props) -> {
     props.put("theme.fontPrototype", new Font("Microsoft YaHei", Font.PLAIN, 12));
});

[weisJ]

Fixed in 0ad6d04