Skip to content

Defering CSS loading #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

brunosabot
Copy link
Contributor

@brunosabot brunosabot commented May 26, 2020

Hi,

this PR is here to solve the #24 issue.
The solution is based on https://web.dev/defer-non-critical-css/

@codecov-commenter
Copy link

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files           2        2           
  Lines          45       45           
  Branches       15       15           
=======================================
  Hits           44       44           
  Misses          1        1           
Impacted Files Coverage Δ
src/gatsby-ssr.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7668ac3...f86a50c. Read the comment docs.

@brunosabot
Copy link
Contributor Author

Hello @weirdpattern!
Is there anything missing/wrong I can fix?

@weirdpattern
Copy link
Owner

weirdpattern commented Jun 22, 2020

Hi @brunosabot no, everything is fine. Sorry I didn't get to this sooner.
I will merge now and publish tonight.

@weirdpattern weirdpattern merged commit 00123bb into weirdpattern:master Jun 22, 2020
@brunosabot
Copy link
Contributor Author

Awesome thanks!

@santiq
Copy link

santiq commented Jun 25, 2020

@weirdpattern Hi there! Can you publish this update?
Thanks!

@weirdpattern
Copy link
Owner

Hey @santiq I'm working on this tonight, but some of the tests are failing for me, so I'm reviewing the merged commits.
I will post another update in a few hours.

Sorry for the delay... I've work in healthcare and things are going crazy at work.

@weirdpattern
Copy link
Owner

All right people, v1.1.10 is finally out.

I apologize for the long wait, hopefully the wait will be worth it.
Reach out to me if you have questions comments or concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants