Simplify TestServiceInventory

weijiii · Jun 6, 2024 · 24bfc18 · 24bfc18
1 parent a97371a
commit 24bfc18
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/discovery/src/test/java/io/airlift/discovery/client/TestServiceInventory.java b/discovery/src/test/java/io/airlift/discovery/client/TestServiceInventory.java
@@ -34,9 +34,6 @@
 import org.testng.annotations.Test;
 
 import java.io.IOException;
-import java.net.InetSocketAddress;
-import java.net.ServerSocket;
-import java.net.URI;
 
 import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.testng.Assert.assertEquals;
@@ -89,21 +86,14 @@ public void testHttpServiceInventory()
 
         Server server = null;
         try (JettyHttpClient httpClient = new JettyHttpClient()) {
-            int port;
-            try (ServerSocket socket = new ServerSocket()) {
-                socket.bind(new InetSocketAddress(0));
-                port = socket.getLocalPort();
-            }
-            URI baseURI = new URI("http", null, "127.0.0.1", port, null, null, null);
-
             HttpConfiguration httpConfiguration = new HttpConfiguration();
             httpConfiguration.setSendServerVersion(false);
             httpConfiguration.setSendXPoweredBy(false);
 
             server = new Server();
 
             ServerConnector httpConnector = new ServerConnector(server, new HttpConnectionFactory(httpConfiguration));
-            httpConnector.setPort(port);
+            httpConnector.setPort(0);
             httpConnector.setName("http");
             server.addConnector(httpConnector);
 
@@ -118,7 +108,7 @@ public void testHttpServiceInventory()
 
             // test
             ServiceInventoryConfig serviceInventoryConfig = new ServiceInventoryConfig()
-                    .setServiceInventoryUri(baseURI);
+                    .setServiceInventoryUri(server.getURI());
 
             ServiceInventory serviceInventory = new ServiceInventory(serviceInventoryConfig,
                     new NodeInfo("test"),