✨ PyogrioReaderIterDataPipe for reading vector OGR files #19
+372
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vectorized vector I/O using OGR!
An iterable-style DataPipe for vector data! Uses pyogrio with geopandas for the I/O. Included a doctest and unit test, added a new section in the API docs and some more intersphinx mappings.
weiji14
commented
Jun 9, 2022
Comment on lines
+33
to
+34
| Extra keyword arguments to pass to | ||
| `pyogrio.read_dataframe <https://pyogrio.readthedocs.io/en/latest/api.html#geopandas-integration>`_. |
There was a problem hiding this comment.
Ideally the intersphinx directive would look like this, but the permalink is not available for some reason. Closest I could get to pyogrio.read_dataframe is using https://pyogrio.readthedocs.io/en/latest/api.html#geopandas-integration.
Suggested change
| Extra keyword arguments to pass to | |
| `pyogrio.read_dataframe <https://pyogrio.readthedocs.io/en/latest/api.html#geopandas-integration>`_. | |
| Extra keyword arguments to pass to :py:func:`pyogrio.read_dataframe`. |
Edit: PR at geopandas/pyogrio#130 to resolve this.
weiji14
force-pushed
the
pyogrio
branch
5 times, most recently
from
8d16ab1
to
f65b70f
Compare
Making a proper build matrix now! Minimal tests (no optional dependencies) run on Python 3.8, while full tests (with all dependencies) run on Python 3.9. Wanted to do Python 3.10 for full tests, but need to wait for rasterio 1.3.0 to come out of beta first.
Conserve GitHub Actions Continuous Integration resources when a Pull Request is in draft mode.
weiji14
commented
Jun 9, 2022
| @@ -21,6 +21,7 @@ classifiers = [ | |||
| python = "^3.8" | |||
| rioxarray = ">=0.10.0" | |||
| torchdata = ">=0.3.0" | |||
| pyogrio = {version = ">=0.4.0a1", extras = ["geopandas"], optional = true} | |||
There was a problem hiding this comment.
Need to bump this to stable pyogrio=0.4.0 version once that is released. Edit: see PR #21.
weiji14
added a commit
that referenced
this pull request
Jun 22, 2022
Using the stable version of pyogrio, patch the intersphinx link as mentioned in #19 (comment), and bumped `geopandas` version in poetry.lock from 0.10.2 to 0.11.0 to reduce number of deprecation warnings. * 📌 Pin minimum pyogrio version to 0.4.0 Bumps [pyogrio](https://github.com/geopandas/pyogrio) from 0.4.0a1 to 0.4.0. - [Release notes](https://github.com/geopandas/pyogrio/releases) - [Changelog](https://github.com/geopandas/pyogrio/blob/v0.4.0/CHANGES.md) - [Commits](geopandas/pyogrio@v0.4.0a1...v0.4.0) * 📝 Update permalink to pyogrio.read_dataframe Get the intersphinx link to point to https://pyogrio.readthedocs.io/en/latest/api.html#pyogrio.read_dataframe. * ⬆️ Bump geopandas from 0.10.2 to 0.11.0 Bumps [geopandas](https://github.com/geopandas/geopandas) from 0.10.2 to 0.11.0. - [Release notes](https://github.com/geopandas/geopandas/releases) - [Changelog](https://github.com/geopandas/geopandas/blob/main/CHANGELOG.md) - [Commits](geopandas/geopandas@v0.10.2...v0.11.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An iterable-style DataPipe for vector data! Also added Python 3.8 job to CI build matrix which doesn't include 'vector' dependencies. That job is also skipped when PR is in draft mode.
i/O handled using pyogrio. IterDataPipe based on https://github.com/pytorch/data/blob/v0.3.0/torchdata/datapipes/iter/load/iopath.py#L37-L83
Preview at https://zen3geo--19.org.readthedocs.build/en/19/api.html#module-zen3geo.datapipes.pyogrio
Note that since
pyogriois made an optional dependency, users would need to dopip install zen3geo[vector]to install the extra 'vector' packages that includespyogrioandgeopandas.TODO:
pyogrioas optional dependencyPyogrioReaderIterDataPipepyogriodependency in one runReferences: