Repository navigation
Fix CVE-2023-50981 in Rabin private key decoding - #1357
Open
Coralesoft wants to merge 1 commit into
Open
Coralesoft wants to merge 1 commit into
Coralesoft wants to merge 1 commit into
Conversation
The BER decoder for Rabin private keys checked m_p and m_q for primality with CRYPTOPP_ASSERT, which is compiled out in release builds. A non-prime m_p or m_q could then reach CalculateInverse and cause ModularSquareRoot to loop indefinitely. Promote the checks to runtime BERDecodeError throws. The decoded key material contains integers, but it is not a valid Rabin private key. CalculateInverse keeps its defensive CRYPTOPP_ASSERT checks as a double-check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the Rabin decode portion of CVE-2023-50981.
InvertibleRabinFunction::BERDecodecheckedm_pandm_qfor primality withCRYPTOPP_ASSERT, which is compiled out in release builds. A non-primem_porm_qcould then reachCalculateInverseand causeModularSquareRootto loop indefinitely.This promotes the checks to runtime
BERDecodeErrorthrows at the decode boundary.CalculateInversekeeps its defensive asserts as a double-check.What changed
CRYPTOPP_ASSERT(IsPrime(...))checks inInvertibleRabinFunction::BERDecodewith runtimeBERDecodeErrorchecks.