sort direct_priority rates on top when prices are in parity #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rates are in parity
wilson-alcantara
approved these changes
Jun 20, 2018
viettienn
reviewed
Jun 20, 2018
| var basePriceA = totalAmountA - totalTaxAmountA, | ||
| basePriceB = totalAmountB - totalTaxAmountB; | ||
|
|
||
| if (basePriceA !== basePriceB) return basePriceA - basePriceB; |
There was a problem hiding this comment.
hey @hoantony, from JIRA ticket, looks like we want to have direct partner on top disregard of the price. Can you confirm if that is the logic? If so, comparing by provider type will be higher priority than by price.
There was a problem hiding this comment.
@viettienn the logic here is correct. We only compare the Provider_types (which DRIECT_PRIORITY has higher priority) only when the prices are in parity. So the sorting conditions will be in order: amount -> provider_type -> ecpc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://wegomushi.atlassian.net/browse/BE-1332
When the provider status is set to direct priority, when rates are in parity, irrespective of the cpc's of various providers the direct priority provider has to be displayed on top.
Status