perf: 优化replace情况下，组件内存回收逻辑

wefront · Feb 11, 2020 · 9aa7852 · 9aa7852
1 parent ea28a92
commit 9aa7852
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/example/components/A.vue b/example/components/A.vue
@@ -7,6 +7,7 @@
     </p>
     <p class="page-link">
       <router-link to="/b">前往B页面</router-link>
+      <!-- <div @click="goB">前往B页面</div> -->
     </p>
   </div>
 </template>
@@ -17,6 +18,11 @@ export default {
     return {
       count: 0
     }
+  },
+  methods: {
+    goB () {
+      this.$router.replace('/b')
+    }
   }
 }
 </script>

diff --git a/example/components/B.vue b/example/components/B.vue
@@ -7,6 +7,7 @@
     </p>
     <p class="page-link">
       <router-link to="/a">前往A页面</router-link>
+      <!-- <div @click="goA">前往A页面</div> -->
     </p>
   </div>
 </template>
@@ -17,6 +18,11 @@ export default {
     return {
       count: 0
     }
+  },
+  methods: {
+    goA () {
+      this.$router.replace('/a')
+    }
   }
 }
 </script>

diff --git a/src/components/feb-alive.js b/src/components/feb-alive.js
@@ -7,7 +7,11 @@ export default (keyName, maxPage) => {
     name: 'feb-alive',
     abstract: true,
     methods: {
-      cacheClear () {
+      cacheClear (key) {
+        // Fix: replace情况下 key未变化，导致实例未被销毁
+        const vnode = this.cache[key]
+        vnode && vnode.componentInstance && vnode.componentInstance.$destroy()
+
         if (maxPage && this.keys.length > parseInt(maxPage)) {
           const oldKey = this.keys[0]
           const oldVnode = this.cache[oldKey]
@@ -112,7 +116,7 @@ export default (keyName, maxPage) => {
             remove(keys, key)
             keys.push(key)
           } else {
-            this.cacheClear()
+            this.cacheClear(key)
             cache[key] = vnode
             keys.push(key)
           }
@@ -131,7 +135,7 @@ export default (keyName, maxPage) => {
             remove(keys, key)
             keys.push(key)
           } else {
-            this.cacheClear()
+            this.cacheClear(key)
             cache[key] = vnode
             keys.push(key)
           }