fix minor bug in Sandstorm username handling #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name was the same as an existing user's handle.
|
(Self-merging because this pertains only to Sandstorm.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the fullname here can cause the username to be set by this logic before the usual uniqification kicks in. The result is that share-by-powerbox can appear to fail, until the recipient actually visits the grain.
The solution is to adjust the call to
Accounts.updateOrCreateFromExternalService()to better match the call in meteor-accounts-sandstrom which gets invoked when the sharing does not go through the powerbox.