Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish 0.15: fix encoding errors with message markers #545

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

freshprince
Copy link
Contributor

Script info

  • Script name: fish.py
  • Version: 0.15

Description

  • fix encoding errors with message markers (provided by @andkem)

Checklist (script update)

  • Author has been contacted
  • Single commit, single file added
  • Commit message format: script_name.py X.Y: …
  • Script version and Changelog have been updated
  • For Python script: works with Python 3 (Python 2 support is optional)
  • Score 100 / 100 displayed by weechat-script-lint

@trygveaa
Copy link
Member

Which version of Python are you using in WeeChat? Run /python version to check.

I haven't tested this, but from looking at the code I don't see a reason to do this change with Python 3.

@trygveaa
Copy link
Member

Nevermind, I see that this is just a change from the upstream repo and that there's an explanation there. (I also see that the encode/decode stuff isn't because of Python 2, but because you're dealing with binary data).

@flashcode flashcode merged commit 5218047 into weechat:master Oct 23, 2023
1 check passed
@flashcode flashcode self-assigned this Oct 23, 2023
@flashcode flashcode added the bug Unexpected problem or unintended behavior label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants