This repository was archived by the owner on May 9, 2022. It is now read-only.
Respect $EDITOR variable #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using $EDITOR to define plain text editor almost became a standard. Most setups already set this variable and expect it to be picked up my other programs. With devlog however, this is not the case. For backwards compatibility, $DEVLOG_EDITOR is kept and would override $EDITOR.
Contributor
Author
|
CI is failing but that doesn't seem to be related to this patch |
Owner
|
Thanks for the pull request! This looks great, I'll merge it and cut a release later today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
$EDITORto define plain text editor almost became a standard. Most setups already set this variable and expect it to be picked up my other programs. With devlog however, this is not the case.For backwards compatibility,
$DEVLOG_EDITORis kept and would override$EDITOR.