Fix room_invitation_payload function issue #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I encountered issues when using the
room_invitation_payloadfunction. An unrelated variable name,InviterId, triggered an error. This pointed towards possible inconsistencies in how the function was handling its response compared to other functions in the system.For more detailed background, please refer to the related issue: Issue #354.
Solution
On examining other functions, specifically the ones related to
friendship, I observed that they directly returned the response. Believing this to be a more consistent and streamlined way of handling the functionality, I applied the same pattern to theroom_invitation_payloadfunction.Changes
room_invitation_payloadfunction to directly return the response, aligning its behavior with that of other functions likefriendship.InviterIdvariable error.I'd appreciate any feedback on these changes and any necessary adjustments you'd recommend.
Thank you!