Handle empty url-list correctly (BEP19)

Commit amended by Feross Aboukhadijeh <feross@feross.org>
webtorrent · Jan 30, 2015 · b316d3a · b316d3a
1 parent d41930f
commit b316d3a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -64,6 +64,12 @@ function decodeTorrentFile (torrent) {
   result.announce = [].concat.apply([], result.announceList)
 
   // handle url-list (BEP19 / web seeding)
+  if (Buffer.isBuffer(torrent['url-list'])) {
+    // some clients set url-list to empty string
+    torrent['url-list'] = torrent['url-list'].length > 0
+      ? [ torrent['url-list'] ]
+      : []
+  }
   result.urlList = (torrent['url-list'] || []).map(function (url) {
     return url.toString()
   })

diff --git a/test/empty-url-list.js b/test/empty-url-list.js
@@ -0,0 +1,11 @@
+var fs = require('fs')
+var parseTorrent = require('../')
+var test = require('tape')
+
+var leavesUrlList = fs.readFileSync(__dirname + '/torrents/leaves-empty-url-list.torrent')
+
+test('parse empty url-list', function (t) {
+  var torrent = parseTorrent(leavesUrlList)
+  t.deepEqual(torrent.urlList, [])
+  t.end()
+})
diff --git a/test/torrents/leaves-empty-url-list.torrent b/test/torrents/leaves-empty-url-list.torrent