fix: replace filestream with fast-blob-stream #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drops filereader dep and readable-stream dep
|
🙌 Thanks for opening this pull request! You're awesome. |
ThaUnknown
changed the title
DiegoRBaquero
approved these changes
Jul 3, 2022
|
🎉 Congrats on getting your first pull request landed! |
webtorrent-bot
pushed a commit
that referenced
this pull request
Jul 3, 2022
## [5.0.4](v5.0.3...v5.0.4) (2022-07-03) ### Bug Fixes * replace filestream with fast-blob-stream ([#171](#171)) ([d93a718](d93a718))
|
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drops filereader dep and readable-stream dep
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain:
What changes did you make? (Give an overview)
Replaced
filestreamwithfast-blob-streamwhich is not only MILES faster, doesn't rely on buffer or readable-stream. It does however use marginally more RAM as it caches 1 piece ahead [if possible]. They are functionally the same.Which issue (if any) does this pull request address?
webtorrent/webtorrent#1971
Is there anything you'd like reviewers to focus on?
Does this cause any issues on node? I don't think node has
file, however it's reliance onblobwhich later versions of node have might be an issue as it uses w3cReadableStreamto create a node-likeReadablewhich is implemented poorly in later node versions, so it might be misused, is this a potential issue?