Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input Field #954

Merged
merged 13 commits into from
Apr 4, 2023
Merged

Input Field #954

merged 13 commits into from
Apr 4, 2023

Conversation

rpominov
Copy link
Contributor

@rpominov rpominov commented Feb 6, 2023 •
edited
Loading

Description

  1. Added InputField aligned with Figma. Demo. Closes Update Input Field component #614
  2. Added NestedSelectButton that should be used as InputField's suffix. Demo
  3. Deprecated TextField
  4. Used InputField instead of TextField in CssValueInput
  5. Added support for <input> in ArrowFocus. Closes Arrow focus with modifier keys & :focus-visible #1364

Steps for reproduction

  1. Open style panel
  2. Test CssValueInput's

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Feb 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 0:07am
webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 0:07am

@rpominov rpominov marked this pull request as ready for review April 4, 2023 12:06
@rpominov rpominov requested a review from kof April 4, 2023 12:06
kof
kof approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great!

@rpominov rpominov merged commit 8c27c75 into main Apr 4, 2023
@rpominov rpominov deleted the input-field branch April 4, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrow focus with modifier keys & :focus-visible Update Input Field component
2 participants
@rpominov @kof