-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make copy paste data agnostic #909
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I miss the information "why" we need it, what does it unblock? |
Do I understand correctly that we are executing copy/paste logic on both, designer and canvas? and you are trying to make it react decoupled? We could do this much easer by simply forwarding the copy/paste event and having the logic in designer only. Basically always trying to just forward events from canvas and that's it. |
Copy paste of instances was implemented closly coupled to our schema. Here I make I implement it with simpler interface without dependency on types. Type and version are instead passed as configuration. Next step will be decoupling instance copy paste from react and simplifying data management with nanostores.
dab4345
to
9bec17e
Compare
The main idea is to split all copy/paste setup from data which was spread over few modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments with not strong opinions. Up to you what to do with them :)
Copy paste of instances was implemented closly coupled to our schema. Here I make I implement it with simpler interface without dependency on types. Type and version are instead passed as configuration.
Next step will be decoupling instance copy paste from react and simplifying data management with nanostores.
Code Review
Before requesting a review
Before merging
.env.example
and thedesigner/env-check.js
if mandatory