Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate styles from Tree to Build #904

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Migrate styles from Tree to Build #904

merged 1 commit into from
Jan 31, 2023

Conversation

TrySound
Copy link
Member

Ref #807

We are gonna store styles on Build table to be able to share them via tokens within project. Here I migrated styles data from Tree table to Build and combined all trees styles on a project into single array.

Rest interface did not changed, the logic is hidden in endpoints for now. Next step will be to move the logic on client side and make rest api thin again.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
  • hi @istarkov, I need you to do
    • detailed review (read every line)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

Ref #807

We are gonna store styles on Build table to be able to share them via
tokens within project. Here I migrated styles data from Tree table to
Build and combined all trees styles on a project into single array.

Rest interface did not changed, the logic is hidden in endpoints for
now. Next step will be to move the logic on client side and make
rest api thin again.
@TrySound TrySound requested a review from istarkov January 31, 2023 09:54
@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 9:56AM (UTC)

@TrySound TrySound merged commit 59e164f into main Jan 31, 2023
@TrySound TrySound deleted the style-source-data branch January 31, 2023 11:37
kof pushed a commit that referenced this pull request Jan 31, 2023
Ref #807

We are gonna store styles on Build table to be able to share them via
tokens within project. Here I migrated styles data from Tree table to
Build and combined all trees styles on a project into single array.

Rest interface did not changed, the logic is hidden in endpoints for
now. Next step will be to move the logic on client side and make rest
api thin again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants