Drop preset styles from db #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
After discussing with @kof figured we do not need to store preset styles in db as after sdk upgrade components may still break. Sdk versioning along with its hardcoded values will solve the problem better.
TrySound
force-pushed
the
drop-preset-styles
branch
from
84e936f to
169fd63
Compare
kof
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @kof figured we do not need to store preset styles in db as after sdk upgrade components may still break.
Sdk versioning along with its hardcoded values will solve the problem better.
Code Review
Before requesting a review
Before merging
.env.exampleand thedesigner/env-check.jsif mandatory