Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate hovered outline to synchronized stores #846

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

TrySound
Copy link
Member

Recently added support for synchronization of non-immerhin stores. Here refactored instance hovering from pubsub to such stores.

Designer and canvas can both set hovered instance id and instance connector subscribes to these changes and sends to designer outline rect.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • test it on preview
  • hi @rpominov, I need you to do
    • detailed review (read every line)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

Recently added support for synchronization of non-immerhin stores.
Here refactored instance hovering from pubsub to such stores.

Designer and canvas can both set hovered instance id and instance
connector subscribes to these changes and sends to designer
outline rect.
@TrySound TrySound requested review from kof and rpominov January 25, 2023 07:33
@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
oss-webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 7:41AM (UTC)
webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 7:41AM (UTC)

@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 25, 2023 07:33 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 25, 2023 07:35 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 25, 2023 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 25, 2023 07:41 Inactive
@TrySound TrySound changed the title Migrate hovered outline with synchronized stores Migrate hovered outline to synchronized stores Jan 25, 2023
@TrySound TrySound merged commit f8fb928 into main Jan 25, 2023
@TrySound TrySound deleted the sync-hovered-stores branch January 25, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants