Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figma tokens #845

Merged
merged 17 commits into from
Jan 25, 2023
Merged

Figma tokens #845

merged 17 commits into from
Jan 25, 2023

Conversation

markxtang
Copy link
Contributor

Description

  1. deleted inner glow tokens since no one is using them.
  2. Organized text styles and atomic text styles such as font-weight and line-height
  3. modified some colors related to the project card component used in the dashboard.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

markxtang and others added 14 commits January 23, 2023 16:51
@markxtang
added type styles for the project cards
9dd3b14
@rpominov
Merge branch 'main' into figma-tokens
bb0860c
@taylornowotny
changes text style names to singular for consistency
6c7bc93
Update figma-design-tokens.ts
bda4535
@taylornowotny
adjusted many colors to improve contrast ratio
9b78e7b 
added background/neutral/dark color
Update figma-design-tokens.ts
261d3a2
@taylornowotny
more color updates persuant to previous update
041fae5
Update figma-design-tokens.ts
48a1263
@markxtang
changed some project card gradients because I changed the constructio…
9c6d425 
…n. It should look the same from the outside
Update figma-design-tokens.ts
90d5005
@markxtang
updated project card>text area from 90% opacity to 100% opacity
d6a623c
Update figma-design-tokens.ts
b093313
@markxtang
deleted inner glow tokens since we're no longer using them
65f2367
Update figma-design-tokens.ts
b9e02c2
@vercel
Copy link

vercel bot commented Jan 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
oss-webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 6:17AM (UTC)
webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 6:17AM (UTC)

@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 25, 2023 03:22 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 25, 2023 03:24 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 25, 2023 06:01 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 25, 2023 06:04 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 25, 2023 06:14 Inactive
@rpominov rpominov merged commit ce12944 into main Jan 25, 2023
@rpominov rpominov deleted the figma-tokens branch January 25, 2023 06:17
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 25, 2023 06:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpominov rpominov rpominov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markxtang @rpominov @taylornowotny