Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to turbo 1.7 #834

Merged
merged 8 commits into from
Jan 29, 2023
Merged

Upgrade to turbo 1.7 #834

merged 8 commits into from
Jan 29, 2023

Conversation

TrySound
Copy link
Member

We use very old version of turborepo which often fails. Here latest one with persistent tasks for watch mode support.

We also need to enable remote caching to get turbo benefits on CI.

While the size of turbo repo grew. Sice 1.3 a lot of artifacts for unpopular systems were removed so we still get smaller node_modules.

du -ckd1 node_modules
-797528
+788132

@kof to enable remote caching need to run pnpm turbo login and then pnpm turbo link.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

We use very old version of turborepo which often fails.
Here latest one with persistent tasks for watch mode support.

We also need to enable remote caching to get turbo benefits on CI.

While the size of turbo repo grew. Sice 1.3 a lot of artifacts for
unpopular systems were removed so we still get smaller node_modules.

```
du -ckd1 node_modules
-797528
+788132
```
@TrySound TrySound requested a review from kof January 22, 2023 13:30
@vercel
Copy link

vercel bot commented Jan 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
oss-webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 29, 2023 at 2:55PM (UTC)
webstudio-designer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 29, 2023 at 2:55PM (UTC)

@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 22, 2023 13:32 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 22, 2023 13:33 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 22, 2023 14:38 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 22, 2023 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 22, 2023 14:51 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 22, 2023 14:52 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 22, 2023 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 22, 2023 14:59 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 22, 2023 15:01 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 22, 2023 15:02 Inactive
@TrySound
Copy link
Member Author

And it does not work..

@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 22, 2023 15:17 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 22, 2023 15:19 Inactive
@vercel vercel bot temporarily deployed to Preview – oss-webstudio-designer January 22, 2023 15:30 Inactive
@vercel vercel bot temporarily deployed to Preview – webstudio-designer January 22, 2023 15:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants