Skip to content

Conversation

@G-OD
Copy link

@G-OD G-OD commented Dec 14, 2025

Description

This fixes an issue where you can't pass system params into a webhook form action.

Steps for reproduction

  1. Create a webhook form
  2. Define an action with system.params in it
  3. Get undefined

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof
Copy link
Member

kof commented Dec 16, 2025

Looking into this, can you please describe a practical use case? for me to better understand what this unlocks

@G-OD
Copy link
Author

G-OD commented Dec 16, 2025

Looking into this, can you please describe a practical use case? for me to better understand what this unlocks

One use case maybe having to post to another endpoint depending on what URL path you're on. Lets say you have a comment section for a blog post and you have the endpoint /posts/123, and to post a comment you need to post to /posts/123/comment. This would require you to dynamically create the action URL using the data variables (in this case the system params).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants