-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: add JSON-LD Schema Markup with AI generation #5506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ai generated schema markup
fix type check
kof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow just saw what you did here 😅
Problem is we haven't built the new AI integration yet and there needs to be:
- defined which provider we want to use, probably vercel gateway to have access to many models
- how payments are going to work, we can't just connect latest model for free for users, only a cheap model would be possible, not big latest LLM, otherwise it will potentially cost more than we get from users.
- Billing that we have implemented for inception along with a new login needs to be used for paying AI credits.
These are the thoughts so far. Please next time discuss in detail with us the feature to avoid building something we can't really merge yet.
|
MAybe for starters we could merge JSONLD editing without AI and put AI on the next step for this? |
| value: schemaMarkup, | ||
| }); | ||
| }} | ||
| pageContext={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, you are not providing the entire page content, what am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kof !
Yes, i intentionally did not send the entire page content. The same reason you mentioned, the model costs, but if we go with a cheap model we should definitely include the page content for better results, even if the cost concern is actually minimal since schema generation is typically a one-time action per page, not continuous usage.
But regarding the AI integration: Yes, makes sense to merge JSON-LD editing without AI first. I can adapt the PR to remove the AI generation feature and keep just the manual schema editing capability.
Should I update the PR to remove the AI parts?
|
In order to decide which schema to use, and then populate it with the appropriate data from the page, the AI needs to have access to schema.org specs, and the page data. There are indeed FREE AI models that could handle this and do the entire structured data generation — eg., there are some fee models available through OpenRouter which we use for testing, and they have performed successfully for us in the past. |
Description
Closes #5443
Adds per-page JSON-LD structured data (Schema Markup) configuration in Page Settings with AI-powered generation.
Features:
<script type="application/ld+json">Technical:
schemaMarkupfield in page meta schemaSchemaMarkupcomponent for builder UIPageSettingsSchemaMarkupcomponent for runtime renderingOPENAI_KEYenv variable)Steps for reproduction
<head>Code Review
Before requesting a review
Before merging
.envfileOPENAI_KEY- Required for AI schema generationOPENAI_ORG- Optional OpenAI organization ID