-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Add Tag Color Picker #5446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
In terms of implementation I would use a Popover component (pls search in the code base how it is used) and combine it with InputField component |
|
honestly even both ColorPicker from style panel and SimpleColorPicker for dashboard can be both in style-system package |
|
Thanks a lot for the feedback! I'll update the code |
|
hey, @kof , I've update according to your feedback. But I didn’t move ColorPicker into design-system because it’s welded to builder-only plumbing (CssValueInput, StyleValue conversions, undo/abort state).Dropping it there would drag all those dependencies along. If we need a shared version, I can follow up by splitting it into a pure UI ColorPicker in design-system plus a thin builder wrapper that adapts to our style model—just let me know. |

Description
Fixes #5445 — adds per-tag color picking so project tags can share consistent, user-defined colors across the dashboard (dialog, cards, filter pills).
Steps for reproduction
propagates everywhere that tag appears.
Code Review
Before requesting a review
Before merging
.envfile