Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Enter support #4627

Merged
merged 11 commits into from
Dec 20, 2024
Merged

experimental: Enter support #4627

merged 11 commits into from
Dec 20, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 20, 2024

Description

ref #4595

  • Enter on block creates new paragraph, text or h1 block if any exists in templates
  • New text added through / command is fully selected
  • If after command block is empty it's replaced with another block
  • esc now closes the / menu
  • backspace on empty now deletes block

Play here

https://p-0b40acbe-34df-4475-8f52-120d5b97da4e-dot-enter.development.webstudio.is/?mode=content

  • - Bug (Next PR)
image to reproduce `Enter`, `/` select Heading, type `blabla`, then `/`, then `Enter`

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov mentioned this pull request Dec 20, 2024
11 tasks
@kof kof changed the title feat: Enter support experimental: Enter support Dec 20, 2024
@istarkov istarkov merged commit a27c8b9 into main Dec 20, 2024
17 checks passed
@istarkov istarkov deleted the enter branch December 20, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants