fix: stop requiring dialog title and description #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref https://discord.com/channels/955905230107738152/1318292995023306803/1318292995023306803 Here removed constraints for dialog title and dialog description in dialog content. Users often delete them though radix starts throwing warnings about it for a while now.
|
Radix will still have warnings if these are deleted, right? I think radix requires them for accessiblity reasons and simply not providing it will be a problem for acessibility. Probably some form of title still needs to be provided but in a way that's hidden or something? |
kof
approved these changes
Dec 17, 2024
TrySound
added a commit
that referenced
this pull request
Dec 17, 2024
Ref https://discord.com/channels/955905230107738152/1318292995023306803/1318292995023306803 Here removed constraints for dialog title and dialog description in dialog content. Users often delete them though radix starts throwing warnings about it for a while now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://discord.com/channels/955905230107738152/1318292995023306803/1318292995023306803
Here removed constraints for dialog title and dialog description in dialog content. Users often delete them though radix starts throwing warnings about it for a while now.