Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide chevron consistently when there are no items in the style panel section #4524

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

kof
Copy link
Member

@kof kof commented Dec 6, 2024

Description

Forgot to set the default for chevron to be hidden when there are no items and no colapsible property passed explicitely

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound December 6, 2024 11:48
@kof kof merged commit b47f179 into main Dec 6, 2024
15 checks passed
@kof kof deleted the fix-chevron branch December 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants