Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace env.d.ts with tsconfig types #3121

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Apr 9, 2024

Latest remix template stopped generating additional file for types.

Code Review

  • hi @istarkov , I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

Latest remix template stopped generating additional file for types.
@TrySound TrySound requested a review from istarkov April 9, 2024 10:51
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Apr 9, 2024 11:06am

@TrySound TrySound merged commit bf0f4ae into main Apr 9, 2024
29 checks passed
@TrySound TrySound deleted the simple-remix-env branch April 9, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants