Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modern tooltips to space control #1877

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Add modern tooltips to space control #1877

merged 3 commits into from
Jul 3, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jun 29, 2023 •
edited
Loading

Description

Based on discussion, now space section tooltips are shown only on label hovers

Supports alt/shift clicks

  • - During hover alt/shift works
  • - In case of multiple properties sources now group them
image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Jun 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jul 3, 2023 11:25am

@istarkov istarkov changed the title Fix-tooltip-space Add modern tooltips to space control Jun 29, 2023
@istarkov istarkov requested a review from TrySound June 29, 2023 09:54
@istarkov istarkov requested a review from kof June 29, 2023 11:03
@istarkov
Add padding description
ce66b85 
Add base tooltips

Fix json

Remove comments

Fix

Fix
@istarkov istarkov force-pushed the fix-tooltip-space branch from e2eee53 to ce66b85 Compare July 3, 2023 06:26
@taylornowotny
Copy link
Contributor

@istarkov please check that the max-width of the tooltips component is 208px as designed

@istarkov istarkov merged commit 88c94b1 into main Jul 3, 2023
@istarkov istarkov deleted the fix-tooltip-space branch July 3, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@kof kof Awaiting requested review from kof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istarkov @taylornowotny @TrySound