Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native node fetch #1875

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Use native node fetch #1875

merged 2 commits into from
Jun 29, 2023

Conversation

TrySound
Copy link
Member

Ref #1191

  • dropped undici (installed one)
  • dropped isomorphic-fetch
  • dropped node-fetch

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
  • hi @istarkov, I need you to do
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@TrySound
Use native node fetch
65f3a1a 
Ref #1191

- dropped undici (installed one)
- dropped isomorphic-fetch
- dropped node-fetch
@TrySound TrySound requested review from kof and istarkov June 28, 2023 20:27
@vercel
Copy link

vercel bot commented Jun 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 28, 2023 8:31pm

@TrySound TrySound merged commit 06a311c into main Jun 29, 2023
@TrySound TrySound deleted the drop-fetch branch June 29, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

@istarkov istarkov istarkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrySound @kof @istarkov